Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enums for player fields #73

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Add enums for player fields #73

merged 2 commits into from
Jan 10, 2025

Conversation

andrewsayre
Copy link
Owner

Description:

New

HeosPlayer

  • New control property to indicate the volume control type when lineout is Fixed.
  • lineout is now an enum of type LineOutLevelType

types module

  • Added LineOutLevelType and VolumeControlType

Related issue (if applicable): closes: #72

Checklist:

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added/updated. No exclusions in .coveragerc permitted.
  • README.MD updated (if necessary)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.76%. Comparing base (5de8286) to head (063cfac).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #73   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          19       19           
  Lines        2108     2114    +6     
=======================================
+ Hits         2103     2109    +6     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsayre andrewsayre merged commit aeeef5a into dev Jan 10, 2025
5 checks passed
@andrewsayre andrewsayre deleted the add_enums branch January 10, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create enums for fields like line_out and control
2 participants