Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support older players with incomplete data #102

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

andrewsayre
Copy link
Owner

Description:

Some older HEOS devices that cannot be updated to the latest firmware version do not report complete player data (such as version, and ip_address, among others). While those devices will likely have other compatibility problems, this change modifies the library to still successfully load them. Adds a new property supported_version to indicate if the version is fully supported by the library.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added/updated. No exclusions in .coveragerc permitted.
  • README.MD updated (if necessary)

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (00fc347) to head (fac5cac).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        23    +1     
  Lines         1978      2008   +30     
=========================================
+ Hits          1978      2008   +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsayre andrewsayre merged commit 1a2fa30 into dev Feb 10, 2025
5 checks passed
@andrewsayre andrewsayre deleted the handle_missing_player_attribs branch February 10, 2025 18:01
@andrewsayre andrewsayre mentioned this pull request Feb 10, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants