Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of command timeouts #100

Merged
merged 3 commits into from
Feb 9, 2025
Merged

Conversation

andrewsayre
Copy link
Owner

Description:

Fixes inability to recover when a command response is received after the timeout period and the original caller has timed out and is no longer waiting for the response. Also improves handling/tracking of incoming responses so that if unexpected responses are received, they are logged and ignored.

Related issue (if applicable): fixes #98

Checklist:

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added/updated. No exclusions in .coveragerc permitted.
  • README.MD updated (if necessary)

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e04cd54) to head (7046b79).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #100   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1974      1978    +4     
=========================================
+ Hits          1974      1978    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsayre andrewsayre merged commit 00fc347 into dev Feb 9, 2025
5 checks passed
@andrewsayre andrewsayre deleted the fix_pending_command_logic branch February 9, 2025 23:18
@andrewsayre andrewsayre mentioned this pull request Feb 10, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError: assert not self._pending_command_event.is_set()
2 participants