Skip to content

Commit

Permalink
chore(package.json): Update dev Dependencies (#78)
Browse files Browse the repository at this point in the history
* chore(package.json): Update dev Dependencies

Bump devDependencies to latest versions

* fix(Jest): Fix failing errors
  • Loading branch information
andreasonny83 authored Oct 2, 2020
1 parent b303e05 commit 280a8bb
Show file tree
Hide file tree
Showing 5 changed files with 31 additions and 23 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: node_js
node_js:
- '10.13'
- '10.16'
before_script:
- export DISPLAY=:99.0
- export CHROME_PATH="$(pwd)/chrome-linux/chrome"
Expand Down
2 changes: 1 addition & 1 deletion __tests__/helpers.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ describe('helpers', () => {
// Arrange
const expectedProp = 'foo';

const Func = function() {
const Func = function () {
this.foo = 1;
};

Expand Down
26 changes: 17 additions & 9 deletions lib/helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,25 @@ const rimraf = require('rimraf');

const clean = () =>
new Promise((resolve, reject) => {
rimraf('./lighthouse/', err => {
rimraf('./lighthouse/', (err) => {
if (err) {
return reject(err);
}

resolve();
return resolve();
});
});

const createDir = () =>
new Promise((resolve, reject) => mkdirp('./lighthouse', err => (err ? reject(err) : resolve())));
new Promise((resolve, reject) => {
mkdirp('./lighthouse', (err) => {
if (err) {
return reject(err);
}

return resolve();
});
});

const scoreReducer = (flags, scoreList) => {
if (flags.score) {
Expand All @@ -39,7 +47,7 @@ const scoreReducer = (flags, scoreList) => {
}, {});
};

const createDefaultConfig = config => {
const createDefaultConfig = (config) => {
if (!config) {
config = {
extends: 'lighthouse:default',
Expand All @@ -54,13 +62,13 @@ const createDefaultConfig = config => {
return config;
};

const getOwnProps = object => {
return Object.keys(object).filter(key => Object.prototype.hasOwnProperty.call(object, key));
const getOwnProps = (object) => {
return Object.keys(object).filter((key) => Object.prototype.hasOwnProperty.call(object, key));
};

const convertToBudgetList = object => {
const convertToBudgetList = (object) => {
return getOwnProps(object)
.filter(key => object[key])
.filter((key) => object[key])
.reduce((acc, key) => {
acc.push({
resourceType: key,
Expand All @@ -70,7 +78,7 @@ const convertToBudgetList = object => {
}, []);
};

const convertToResourceKey = key => 'resource' + key.charAt(0).toUpperCase() + key.slice(1);
const convertToResourceKey = (key) => 'resource' + key.charAt(0).toUpperCase() + key.slice(1);

module.exports = {
clean,
Expand Down
6 changes: 3 additions & 3 deletions lib/lighthouse-reporter.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const launchChromeAndRunLighthouse = async (url, chromeFlags, lighthouseFlags, c
const { budget } = flags;

const budgetConfigs = getOwnProps(budget)
.filter(key => budget[key] && (key === 'counts' || key === 'sizes'))
.filter((key) => budget[key] && (key === 'counts' || key === 'sizes'))
.reduce(
(acc, key) => {
acc[convertToResourceKey(key)] = convertToBudgetList(budget[key]);
Expand Down Expand Up @@ -114,7 +114,7 @@ const createJsonReport = (results, flags) => {
return null;
};

const createCategoryReport = results => {
const createCategoryReport = (results) => {
const { categories } = results;

return getOwnProps(categories).reduce((categoryReport, categoryName) => {
Expand All @@ -124,7 +124,7 @@ const createCategoryReport = results => {
}, {});
};

const createBudgetsReport = results => {
const createBudgetsReport = (results) => {
const items =
(results.audits &&
results.audits['performance-budget'] &&
Expand Down
18 changes: 9 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@
"update-notifier": "^4.0.0"
},
"devDependencies": {
"@types/jest": "^24.0.15",
"@types/jest": "^26.0.14",
"@types/ora": "^3.2.0",
"all-contributors-cli": "^6.8.1",
"chalk": "^2.4.2",
"jest": "^24.8.0",
"np": "^5.0.3",
"prettier": "^1.18.2",
"snyk": "^1.362.0",
"xo": "^0.32.1"
"all-contributors-cli": "^6.17.4",
"chalk": "^4.1.0",
"jest": "^26.4.2",
"np": "^6.5.0",
"prettier": "^2.1.2",
"snyk": "^1.406.0",
"xo": "^0.33.1"
},
"keywords": [
"devtools",
Expand All @@ -48,7 +48,7 @@
"LICENSE"
],
"engines": {
"node": ">=10.13"
"node": ">=10"
},
"xo": {
"prettier": true,
Expand Down

0 comments on commit 280a8bb

Please sign in to comment.