Merge pull request #6 from andreasGBL/develop

Several Bug Fixes / Quality of Life improvements

README.md

@@ -81,6 +81,7 @@ Alternatively just download the latest [Release](https://github.com/andreasGBL/V
 - when the hardware accelerated codecs fail, try updating your drivers - if that doesn't work try different parameters and maybe try to change some parameters back to "As Input"
 - AMD hardware acceleration is just barely tested
 - A maximum video length of 23:59:59.999 (up to 24 hours of video) is supported
+- No AV1 support yet, although it is already supported by ffmpeg
 
 # License
 This open source software is licensed under [GPLv3](LICENSE).

src/VideoCutWindow/videocutwindow.cpp

@@ -59,7 +59,10 @@ void VideoCutWindow::setInitialStartAndEnd(QTime const & start, QTime const & en
 void VideoCutWindow::closeWindow(QTime start, QTime end, bool cancelled)
 {
 	emit newCutInformation(start, end, cancelled);
-	mediaPlayer->pause();
+	// only pause when the end of the video isn't reached yet to prevent weird "DirectShowPlayerService::doRender: Unresolved error code 0x80040218 (IDispatch error #24)" bug:
+	if (getTimeForVideoPosition(mediaPlayer->position()) < currentVideo->length) { 
+		mediaPlayer->pause(); 
+	}
 	this->setVisible(false);
 }
 

src/filedropwidget.cpp

@@ -7,7 +7,7 @@
 #include <QMimeData>
 #include <QRegularExpression>
 #include <QDir>
-
+#include <QMessageBox>
 
 #include <iostream>
 #include <cstdio>
@@ -59,6 +59,19 @@ void FileDropWidget::dropEvent(QDropEvent * event)
 	if (acceptMimeType(mimeData)) {
 		//accept File
 		QString path = mimeData->text().split("file:///")[1];
+		bool unsupported_chars = false;
+		QString unsupported("");
+		for (QChar ch : path) {
+			if (ch.unicode() > 127) {
+				unsupported_chars = true;
+				unsupported += ch;
+			}
+		}
+		if (unsupported_chars) {
+			std::cout << "Unsupported Characters in File name.\n";
+			QMessageBox::critical(nullptr, "Error", "Unsupported Characters in File name:\n(\"" + unsupported + "\")\n");
+			return;
+		}
 		std::cout << "New File: " << path.toStdString() << std::endl;
 		setText(tr(breakLines(path, 40).toStdString().c_str()));