Fix test_full_manual_update_workflow

Author: andreas-el

src/ert/gui/main_window.py

@@ -122,6 +122,20 @@ def select_central_widget(self) -> None:
         if actor:
             index_name = actor.property("index")
 
+            if index_name == "Manage experiments":
+                if self._manage_experiments_panel:
+                    self._manage_experiments_panel.close()
+                self._manage_experiments_panel = ManageExperimentsPanel(
+                    self.ert_config,
+                    self.notifier,
+                    self.ert_config.model_config.num_realizations,
+                )
+
+                self.central_panels_map["Manage experiments"] = (
+                    self._manage_experiments_panel
+                )
+                self.central_layout.addWidget(self._manage_experiments_panel)
+
             if index_name == "Create plot" and not self._plot_window:
                 self._plot_window = PlotWindow(self.config_file, self)
                 self.central_layout.addWidget(self._plot_window)
@@ -193,16 +207,6 @@ def post_init(self) -> None:
             if menubar:
                 menubar.addMenu(self.plugins_tool.get_menu())
 
-        self._manage_experiments_panel = ManageExperimentsPanel(
-            self.ert_config,
-            self.notifier,
-            self.ert_config.model_config.num_realizations,
-        )
-
-        self.central_panels_map["Manage experiments"] = self._manage_experiments_panel
-        self._manage_experiments_panel.hide()
-        self.central_layout.addWidget(self._manage_experiments_panel)
-
     def _add_sidebar_button(self, name: str, icon: QIcon) -> QPushButton:
         button = QPushButton(self.side_frame)
         button.setFixedSize(60, 60)
@@ -213,6 +217,8 @@ def _add_sidebar_button(self, name: str, icon: QIcon) -> QPushButton:
         button.setIconSize(icon_size)
         button.setIcon(icon)
         button.setToolTip(name)
+        objname = name.replace(" ", "_")
+        button.setObjectName(f"button_{objname}")
         self.vbox_layout.addWidget(button)
 
         button.clicked.connect(self.select_central_widget)

tests/ert/ui_tests/gui/test_full_manual_update_workflow.py

@@ -5,6 +5,7 @@
 from qtpy.QtCore import Qt
 from qtpy.QtWidgets import (
     QComboBox,
+    QPushButton,
     QTreeView,
     QWidget,
 )
@@ -14,7 +15,7 @@
 from ert.gui.simulation.experiment_panel import ExperimentPanel
 from ert.gui.simulation.manual_update_panel import ManualUpdatePanel
 from ert.gui.simulation.run_dialog import RunDialog
-from ert.gui.tools.manage_experiments import ManageExperimentsTool
+from ert.gui.tools.manage_experiments import ManageExperimentsPanel
 from ert.gui.tools.manage_experiments.storage_widget import StorageWidget
 from ert.run_models.evaluate_ensemble import EvaluateEnsemble
 from ert.run_models.manual_update import ManualUpdate
@@ -44,16 +45,14 @@ def test_manual_analysis_workflow(ensemble_experiment_has_run, qtbot):
     qtbot.mouseClick(run_experiment, Qt.LeftButton)
     # The Run dialog opens, wait until done appears, then click done
     run_dialog = wait_for_child(gui, qtbot, RunDialog)
-    qtbot.waitUntil(run_dialog.done_button.isVisible, timeout=100000)
+    qtbot.waitUntil(lambda: not run_dialog.done_button.isHidden(), timeout=10000)
     qtbot.waitUntil(lambda: run_dialog._tab_widget.currentWidget() is not None)
     qtbot.mouseClick(run_dialog.done_button, Qt.LeftButton)
 
-    # Open the manage experiments dialog
-    manage_tool = gui.tools["Manage experiments"]
-    manage_tool.trigger()
-
-    assert isinstance(manage_tool, ManageExperimentsTool)
-    experiments_panel = manage_tool._manage_experiments_panel
+    button_manage_experiments = gui.findChild(QPushButton, "button_Manage_experiments")
+    assert button_manage_experiments
+    qtbot.mouseClick(button_manage_experiments, Qt.LeftButton)
+    experiments_panel = gui.findChild(ManageExperimentsPanel)
     assert experiments_panel
 
     # In the "create new case" tab, it should now contain "iter-1"