Remove test that checks if rundialog can be closed

The Rundialog cannot be closed anymore

Author: andreas-el

tests/ert/ui_tests/gui/test_main_window.py

@@ -8,15 +8,13 @@
 
 import numpy as np
 import pytest
-from pytestqt.qtbot import QtBot
 from qtpy.QtCore import Qt, QTimer
 from qtpy.QtWidgets import (
     QAction,
     QCheckBox,
     QComboBox,
     QDoubleSpinBox,
     QMenuBar,
-    QMessageBox,
     QPushButton,
     QToolButton,
     QTreeView,
@@ -34,11 +32,9 @@
 from ert.gui.main import ErtMainWindow, GUILogHandler, _setup_main_window
 from ert.gui.simulation.experiment_panel import ExperimentPanel
 from ert.gui.simulation.run_dialog import RunDialog
-from ert.gui.simulation.view import RealizationWidget
 from ert.gui.suggestor import Suggestor
 from ert.gui.suggestor._suggestor_message import SuggestorMessage
 from ert.gui.tools.event_viewer import add_gui_log_handler
-from ert.gui.tools.file.file_dialog import FileDialog
 from ert.gui.tools.manage_experiments import (
     ManageExperimentsPanel,
 )
@@ -57,7 +53,6 @@
     SingleTestRun,
 )
 from ert.services import StorageService
-from ert.storage import open_storage
 
 from .conftest import (
     add_experiment_manually,
@@ -164,98 +159,6 @@ def test_gui_shows_a_warning_and_disables_update_when_parameters_are_missing(
         assert gui.windowTitle().startswith("ERT - poly-no-gen-kw.ert")
 
 
-def test_that_run_dialog_can_be_closed_while_file_plot_is_open(
-    snake_oil_case_storage: ErtConfig, qtbot: QtBot
-):
-    """
-    This is a regression test for a crash happening when
-    closing the RunDialog with a file open.
-    """
-
-    snake_oil_case = snake_oil_case_storage
-    args_mock = Mock()
-    args_mock.config = "snake_oil.ert"
-
-    def handle_run_path_error_dialog(gui: ErtMainWindow, qtbot: QtBot):
-        mb = gui.findChild(QMessageBox, "RUN_PATH_ERROR_BOX")
-
-        if mb is not None:
-            assert mb
-            assert isinstance(mb, QMessageBox)
-            # Continue without deleting the runpath
-            qtbot.mouseClick(mb.buttons()[0], Qt.LeftButton)
-
-    def handle_run_path_dialog(
-        gui: ErtMainWindow,
-        qtbot: QtBot,
-        delete_run_path: bool = True,
-        expect_error: bool = False,
-    ):
-        mb = gui.findChild(QMessageBox, "RUN_PATH_WARNING_BOX")
-
-        if mb is not None:
-            assert mb
-            assert isinstance(mb, QMessageBox)
-
-            if delete_run_path:
-                qtbot.mouseClick(mb.checkBox(), Qt.LeftButton)
-
-            qtbot.mouseClick(mb.buttons()[0], Qt.LeftButton)
-            if expect_error:
-                QTimer.singleShot(
-                    1000, lambda: handle_run_path_error_dialog(gui, qtbot)
-                )
-
-    with StorageService.init_service(
-        project=os.path.abspath(snake_oil_case.ens_path),
-    ), open_storage(snake_oil_case.ens_path, mode="w") as storage:
-        gui = _setup_main_window(snake_oil_case, args_mock, GUILogHandler(), storage)
-        experiment_panel = gui.findChild(ExperimentPanel)
-
-        run_experiment = experiment_panel.findChild(QWidget, name="run_experiment")
-        assert run_experiment
-        assert isinstance(run_experiment, QToolButton)
-
-        QTimer.singleShot(
-            1000, lambda: handle_run_path_dialog(gui, qtbot, delete_run_path=True)
-        )
-        qtbot.mouseClick(run_experiment, Qt.LeftButton)
-
-        run_dialog = wait_for_child(gui, qtbot, RunDialog)
-        qtbot.waitUntil(run_dialog.done_button.isVisible, timeout=100000)
-        fm_step_overview = run_dialog._fm_step_overview
-
-        qtbot.waitUntil(fm_step_overview.isVisible, timeout=20000)
-        qtbot.waitUntil(run_dialog.done_button.isVisible, timeout=200000)
-
-        realization_widget = run_dialog.findChild(RealizationWidget)
-
-        click_pos = realization_widget._real_view.rectForIndex(
-            realization_widget._real_list_model.index(0, 0)
-        ).center()
-
-        with qtbot.waitSignal(realization_widget.itemClicked, timeout=30000):
-            qtbot.mouseClick(
-                realization_widget._real_view.viewport(),
-                Qt.LeftButton,
-                pos=click_pos,
-            )
-
-        click_pos = fm_step_overview.visualRect(
-            fm_step_overview.model().index(0, 4)
-        ).center()
-        qtbot.mouseClick(fm_step_overview.viewport(), Qt.LeftButton, pos=click_pos)
-
-        qtbot.waitUntil(run_dialog.findChild(FileDialog).isVisible, timeout=30000)
-
-        with qtbot.waitSignal(run_dialog.accepted, timeout=30000):
-            run_dialog.close()  # Close the run dialog by pressing 'x' close button
-
-        # Ensure that once the run dialog is closed
-        # another simulation can be started
-        assert run_experiment.isEnabled()
-
-
 @pytest.mark.usefixtures("set_site_config")
 def test_help_buttons_in_suggester_dialog(tmp_path, qtbot):
     """