Skip to content

Commit

Permalink
add deprecation warning for the runtests_queue setting
Browse files Browse the repository at this point in the history
  • Loading branch information
amyasnikov committed Jan 24, 2025
1 parent fdf8809 commit 03ede84
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion validity/dependencies.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import warnings
from typing import Annotated

from dimi.scopes import Context, Singleton
Expand Down Expand Up @@ -28,7 +29,14 @@ def django_settings():

@di.dependency(scope=Singleton, add_return_alias=True)
def validity_settings(django_settings: Annotated[LazySettings, django_settings]) -> ValiditySettings:
return ValiditySettings.model_validate(django_settings.PLUGINS_CONFIG.get("validity", {}))
settings = django_settings.PLUGINS_CONFIG.get("validity", {})
if settings.get("runtests_queue"):
warnings.warn(
'"runtests_queue" Validity setting is deprecated, use "custom_queues.runtests" instead.',
FutureWarning,
stacklevel=1,
)
return ValiditySettings.model_validate(settings)


@di.dependency(scope=Context, add_return_alias=True)
Expand Down

0 comments on commit 03ede84

Please sign in to comment.