Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo or Screenshots? #20

Open
prologic opened this issue Oct 11, 2021 · 8 comments
Open

Demo or Screenshots? #20

prologic opened this issue Oct 11, 2021 · 8 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@prologic
Copy link

Are there any demo apps of this in use or screenshots?

I'm reconsidering using this library (https://git.mills.io/yarnsocial/goryon/issues/53) and before I make that decision I need to know and understand whether it fits our needs.

Thanks!

@ammaratef45
Copy link
Owner

@prologic Thanks for considering the package

The example app is a good demo to run (web is supported to giving it a try takes less than a minute)

There are some youtube videos that describe the development process and some demoing in the way:

I also think it's a good idea to add some screenshots to the readme file to show the result of different ways to use it.

@ammaratef45 ammaratef45 added documentation Improvements or additions to documentation good first issue Good for newcomers enhancement New feature or request help wanted Extra attention is needed labels Oct 11, 2021
@prologic
Copy link
Author

Thanks! I'll check this out this evening👌

@prologic
Copy link
Author

(⎈ |local:default)
prologic@Jamess-iMac
Mon Oct 11 18:05:31
~/tmp/flutter_markdown_editor/example
 (main) 0
$ flutter build web
Running "flutter pub get" in example...                             7.5s

Building without sound null safety
For more information see https://dart.dev/null-safety/unsound-null-safety
...

Oooof 😢 Do you think you could update this package and make a new release with Null Saftey?

I've upgraded Goryon's codebase already and I don't want to use this package without NullSafetyy 🤗

@prologic
Copy link
Author

I built the web version with flutter build web and ooops none of the buttons works 🤔

@prologic
Copy link
Author

I'll try the ios version and install to my iPhone...

@prologic
Copy link
Author

Okay it "sort of" work son my iPhone. But mate, I have to say, I can't use this. The core functionality is there but it needs a lot of polish, the UX is pretty rough in my opinion.

It also needs a way to support custom buttons as I need:

  • Upload Photo / Select Photo from device
  • Upload Video / Select Video from device

I do like the prompt/popup though for entering links. That's a good idea, but again needs a bit of UX polish.

@prologic
Copy link
Author

prologic commented Oct 11, 2021

I also observed the following errors/warnings when running the ios version:

Screen Shot 2021-10-11 at 18 43 11

@ammaratef45
Copy link
Owner

@prologic Thanks for the amazing feedback, if you would like you can open issues for the different problems to track their fix and you are also welcome to open PRs as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants