Skip to content

Commit

Permalink
Use taker's burning man selection height
Browse files Browse the repository at this point in the history
When a taker takes a trade he sends his burning man selection height to
the maker. After validating the taker's burning man selection height, he
has to use the taker's burning man selection height to verify the
taker's delayed payout transaction because the maker's and taker's
burning man selection height could be different. The current
implementation uses the maker's burning man selection height. This can
cause failed trades.

Relates to bisq-network#7393.
  • Loading branch information
alvasw committed Feb 14, 2025
1 parent 96355d7 commit df78cb7
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ protected void run() {
checkArgument(areBurningManSelectionHeightsValid,
"takersBurningManSelectionHeight does no match makersBurningManSelectionHeight");

processModel.setBurningManSelectionHeight(makersBurningManSelectionHeight);
processModel.setBurningManSelectionHeight(takersBurningManSelectionHeight);

// We set the taker fee only in the processModel yet not in the trade as the tx was only created but not
// published yet. Once it was published we move it to trade. The takerFeeTx should be sent in a later
Expand Down

0 comments on commit df78cb7

Please sign in to comment.