Always show ARS blue rate popup

We show the ARS blue rate popup whenever the user creates a payment
method and ARS is selected. Therefore, it makes sense to always show the
ARS blue rate popup.

Author: alvasw

desktop/src/main/java/bisq/desktop/components/paymentmethods/ArsBlueRatePopup.java

@@ -5,24 +5,19 @@
 import bisq.core.locale.FiatCurrency;
 import bisq.core.locale.Res;
 import bisq.core.locale.TradeCurrency;
-import bisq.core.user.DontShowAgainLookup;
 
 public class ArsBlueRatePopup {
     public static boolean isTradeCurrencyArgentinePesos(TradeCurrency tradeCurrency) {
         FiatCurrency arsCurrency = new FiatCurrency("ARS");
         return tradeCurrency.equals(arsCurrency);
     }
 
-    public static void showMaybe() {
-        String key = "arsBlueMarketNotificationPopup";
-        if (DontShowAgainLookup.showAgain(key)) {
-            new Popup()
-                    .headLine(Res.get("popup.arsBlueMarket.title"))
-                    .information(Res.get("popup.arsBlueMarket.info"))
-                    .actionButtonText(Res.get("shared.iUnderstand"))
-                    .hideCloseButton()
-                    .dontShowAgainId(key)
-                    .show();
-        }
+    public static void show() {
+        new Popup()
+                .headLine(Res.get("popup.arsBlueMarket.title"))
+                .information(Res.get("popup.arsBlueMarket.info"))
+                .actionButtonText(Res.get("shared.iUnderstand"))
+                .hideCloseButton()
+                .show();
     }
 }

desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java

@@ -123,7 +123,7 @@ public TradeCurrency fromString(String s) {
             updateFromInputs();
 
             if (ArsBlueRatePopup.isTradeCurrencyArgentinePesos(selectedCurrency)) {
-                ArsBlueRatePopup.showMaybe();
+                ArsBlueRatePopup.show();
             }
         });
     }
@@ -316,7 +316,7 @@ void fillUpFlowPaneWithCurrencies(boolean isEditable, FlowPane flowPane,
                 paymentAccount.addCurrency(e);
 
                 if (ArsBlueRatePopup.isTradeCurrencyArgentinePesos(e)) {
-                    ArsBlueRatePopup.showMaybe();
+                    ArsBlueRatePopup.show();
                 }
 
             } else {
@@ -328,7 +328,7 @@ void fillUpFlowPaneWithCurrencies(boolean isEditable, FlowPane flowPane,
         flowPane.getChildren().add(checkBox);
 
         if (isCurrencySelected && ArsBlueRatePopup.isTradeCurrencyArgentinePesos(e)) {
-            ArsBlueRatePopup.showMaybe();
+            ArsBlueRatePopup.show();
         }
     }
 

desktop/src/main/java/bisq/desktop/util/GUIUtil.java

@@ -1109,7 +1109,7 @@ public TradeCurrency fromString(String string) {
             onTradeCurrencySelectedHandler.accept(selectedCurrency);
 
             if (ArsBlueRatePopup.isTradeCurrencyArgentinePesos(selectedCurrency)) {
-                ArsBlueRatePopup.showMaybe();
+                ArsBlueRatePopup.show();
             }
         });