Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ww.init_series(schema=schema) to retain origin in partial dependence #3847

Open
tamargrey opened this issue Nov 17, 2022 · 0 comments
Open
Labels
new feature Features which don't yet exist.

Comments

@tamargrey
Copy link
Contributor

  • Currently, we explicitly pass along the origin and logical type when initializing woodwork on the updated partial dependence column. This means that if predictions ever become dependent on another woodwork attribute, we have to remember to add it at partial dependence, or we'll get incorrect predictions. To avoid that, we can pass along the original column's woodwork schema, but we have to wait for that ability to be implemented in ww.init_schema in this woodwork issue.

Once that issue is completed and released, we should be able to do the following in partial dependence:

X_eval.ww[variable] = ww.init_series(
                        part_dep_column,
                        schema=X_eval.ww.columns[variable]
                    )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Features which don't yet exist.
Projects
None yet
Development

No branches or pull requests

1 participant