PP-13360 csrf express middleware #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlsteers
force-pushed
the
pp-13360/csrf_module
branch
from
33dbf7e to
74ecebb
Compare
DomBelcher
reviewed
Dec 16, 2024
| */ | ||
| const checkToken = (req, res, next) => { | ||
| const csrfSecret = req[sessionKey][secretKey] | ||
| const csrfToken = (req.body && req.body[tokenKey]) || (req.query && req.query[tokenKey]) |
There was a problem hiding this comment.
Should it be possible to pass the csrf token in a query paramter? since the validation is only enforced on PUT or POST operations I think it should only ever be expected in the body, unless there's a case where we are passing in a query parameter
There was a problem hiding this comment.
glad you asked :D, in the case of multipart/form-data encoded POSTs we don't have (easy) access to the body when validating the token so the token is passed as a query parameter. Basically anywhere we use a file input type
nlsteers
force-pushed
the
pp-13360/csrf_module
branch
from
9f1595d to
9a153c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT