Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gunicorn to 23.0.0 and eventlet to 0.38.2 #4339

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

quis
Copy link
Member

@quis quis commented Jan 14, 2025

The API is using a version of Gunicorn (20.1.0) which is 3 years and 8 months out of date:

It has a high severity security vulnerability: https://security.snyk.io/package/pip/gunicorn/20.1.0

Additionally, because we are referencing a dependency by SHA, Dependabot can’t work out what version we are using and doesn’t flag this vulnerability.

In order to deploy this we need to figure out:

  • if we still expect the possibility of a performance regression
  • how to test this

@quis quis added the dependencies Pull requests that update a dependency file label Jan 15, 2025
@quis quis changed the title Bump gunicorn to 23.0.0 Bump gunicorn to 23.0.0 and eventlet to 0.38.2 Jan 15, 2025
@risicle
Copy link
Member

risicle commented Jan 24, 2025

Gonna rebase & test this...

quis added 2 commits January 24, 2025 09:41
The API is using a version of Gunicorn which is 3 years and 6 months
out of date.
benoitc/gunicorn@1299ea9

It has a high severity security vulnerability:
https://security.snyk.io/package/pip/gunicorn/21.0.0

Additionally, because we are referencing a dependency by SHA, Dependabot
can’t work out what version we are using and doesn’t flag this
vulnerability.

In order to deploy this we need to figure out:
- if we still expect the possibility of a performance regression
- how to test this
@risicle
Copy link
Member

risicle commented Jan 24, 2025

Unfortunately my testing seems to be suggesting that this is worse. I need to look deeper into this..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants