Skip to content

Commit

Permalink
Rename job to test so it can be set as required status check
Browse files Browse the repository at this point in the history
govuk-saas-config [looks for](https://github.com/alphagov/govuk-saas-config/blob/395a713522985d7cdfc9ef5320892cace7a72042/github/lib/configure_repo.rb#L115-L120) a job named `test`, and sets this as a 'required' status check if it exists.

Defining one here means we'll ensure that tests have to pass in order for PRs to be merged, which is standard best practice.

Trello: https://trello.com/c/3CYpdFw4/3480-set-stricter-branch-protection-defaults
  • Loading branch information
ChrisBAshton authored Apr 11, 2024
1 parent 20c0c1b commit 88cd4e9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
pull_request:

jobs:
run-jasmine:
test:
name: Test Extension JS
runs-on: ubuntu-latest
steps:
Expand Down

0 comments on commit 88cd4e9

Please sign in to comment.