No slimmer #4621
Draft
No slimmer #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
force-pushed
the
no-slimmer
branch
from
279f222 to
613c792
Compare
- Layouts will be updated in a later commit (one each for application, homepage, and landing_page). - Remove the specific setting of gem_layout for travel_advice_controller and related test - this is the default anyway, so it's not clear that this controller needs special treatment.
- Update layout to use layout_for_public component directly - Update JS to include JS support for layout components - Update SCSS file to build component support CSS We won't get this from static any more - Add exclude_css_from_static = false to configuration - We can simplify the application layout code a little because we don't have to handle homepage specific code (we'll add a homepage layout).
KludgeKML
force-pushed
the
no-slimmer
branch
from
613c792 to
23c21da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
https://trello.com/c/qWE04tVs/304-remove-slimmer-frontend
How
Screenshots?