Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dfe autocomplete #867

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Update dfe autocomplete #867

merged 2 commits into from
Jan 3, 2024

Conversation

DavidBiddle
Copy link
Contributor

What problem does this pull request solve?

Trello card: None

Updates the dfe-autocomplete package to the latest commit in that repo. This means that:

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Updates our version of dfe-autocomplete to the latest commit. This will
give us the latest changes, including:

- using the precompiled version instead of building it ourselves on
every npm install
- removal of the ie8 mixin
We no longer need this workaround, since the mixin it's patching is no
longer being used by the dfe-autocomplete package.
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DavidBiddle DavidBiddle marked this pull request as ready for review January 3, 2024 08:59
@DavidBiddle DavidBiddle added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit f828c99 Jan 3, 2024
@DavidBiddle DavidBiddle deleted the update-dfe-autocomplete branch January 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants