Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page IDs to summary list rows for page summary component #1809

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

lfdebrux
Copy link
Member

What problem does this pull request solve?

We already have IDs for each summary list row for a condition, this PR adds IDs for each summary list row for a page. This will be useful for automation tools such as our end to end tests.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

We already have IDs for each summary list row for a condition, this
commit adds IDs for each summary list row for a page. This will be
useful for automation tools such as our end to end tests.
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1809.review.forms.service.gov.uk/.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For more details please see the review app wiki page

@lfdebrux lfdebrux merged commit a823deb into main Feb 26, 2025
7 checks passed
@lfdebrux lfdebrux deleted the ldeb-add-page-id-to-page-list-summary-rows branch February 26, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants