Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.review_apps: use app autoscaling to turn review apps off at night, weekends #1806

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

AP-Hunt
Copy link
Member

@AP-Hunt AP-Hunt commented Feb 25, 2025

Note

This PR has been raised so that we can check the review app in the morning and see if it went down to zero.

A matching PR has been raised to give the role permission to do this: https://github.com/alphagov/forms-deploy/pull/1391

What problem does this pull request solve?

Trello card: #1806

AWS App Autoscaling allows us to scale AWS ECS services up and down on a schedule. To save money, we want to turn them off at 6pm each day, and then back on at 8am Monday to Friday.

The result should be them being turned off from 6pm to 8am Monday to Friday, and all day on weekends.

Things to consider when reviewing

I let the scaling rules take effect overnight to demonstrate them working against the review app for this PR

image

image

@AP-Hunt AP-Hunt force-pushed the turn_review_apps_off_overnight branch from 74dc18f to 00f978b Compare February 25, 2025 17:31
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1806.review.forms.service.gov.uk/.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For more details please see the review app wiki page

@AP-Hunt AP-Hunt marked this pull request as ready for review February 26, 2025 10:15
…eekends

AWS App Autoscaling allows us to scale AWS ECS services up and down on a
schedule. To save money, we want to turn them off at 6pm each day, and then
back on at 8am Monday to Friday.

The result should be them being turned off from 6pm to 8am Monday to Friday,
and all day on weekends.
@AP-Hunt AP-Hunt force-pushed the turn_review_apps_off_overnight branch from 00f978b to e2a6946 Compare February 26, 2025 10:15
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at https://pr-1806.review.forms.service.gov.uk/.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For more details please see the review app wiki page

Copy link
Contributor

@sarahseewhy sarahseewhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🪄

I see no easter eggs 🥚

@AP-Hunt AP-Hunt merged commit d33506a into main Feb 26, 2025
7 checks passed
@AP-Hunt AP-Hunt deleted the turn_review_apps_off_overnight branch February 26, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants