[DO NOT MERGE] Remove browse__breadcrumb-border
#3976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove
browse__breadcrumb-border(from Browse pages)https://trello.com/c/3EkNY2Bs/3254-prepare-a-pr-to-turn-off-the-blue-border-at-the-bottom-of-the-header?filter=label:Frontend%20devs
Why
The blue bar beneath the current black header on GOV.UK pages is applied by https://github.com/alphagov/govuk_publishing_components. We want to remove this, and will need to update the gem accordingly. However the blue bar code is very old and complicated and we’re not sure how best to do it.
Visual Changes
Before
After
Anything else
alphagov/govuk_publishing_components#4616
alphagov/frontend#4627
alphagov/static#3578