Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for writing pandas DataFrame and Series #55

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add support for writing pandas DataFrame and Series #55

wants to merge 5 commits into from

Conversation

briancappello
Copy link
Contributor

This PR

  • adds support for writing pandas DataFrame and Series objects (replaces correctly support writing pd.Series and pd.DataFrame #31)
  • consolidates as much logic as possible between the JsonRpcClient and GRPCClient (but unfortunately the request formats are slightly different, so there's still some extra verbosity)
  • I have tested this writing 32bit and 64bit values, both work, however the usability of this PR is much improved by marketstore #363
    • without 363, the client is responsible for knowing ahead-of-time the which types marketstore uses for each TBK. Which IMO is kinda not great :)

NOTE: branched off of #52, so hopefully that will be merged sooner rather than later

@briancappello briancappello mentioned this pull request Aug 8, 2020
Closed
@briancappello briancappello force-pushed the consolidate-write-reqs-and-support-pandas branch from 50cb123 to e832205 Compare August 10, 2020 11:29
@briancappello briancappello force-pushed the consolidate-write-reqs-and-support-pandas branch from e832205 to c7aed59 Compare August 10, 2020 11:30
@jaggas
Copy link

jaggas commented Nov 25, 2021

Is there any plan to integrate this pull request? This feature would be pretty nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briancappello @jaggas