fix(allure-playwright): ignore route.continue() steps (fixes #1139, f…

…ixes #414, via #1140)
allure-framework · Sep 16, 2024 · 570ed4b · 570ed4b
1 parent cf6451b
commit 570ed4b
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 3 deletions.
diff --git a/packages/allure-playwright/src/index.ts b/packages/allure-playwright/src/index.ts
@@ -211,6 +211,19 @@ export class AllureReporter implements ReporterV2 {
     this.startedTestCasesTitlesCache.push(titleMetadata.cleanTitle);
   }
 
+  #shouldIgnoreStep(step: TestStep) {
+    if (!this.options.detail && step.category !== "test.step") {
+      return true;
+    }
+
+    // ignore noisy route.continue()
+    if (step.category === "pw:api" && step.title === "route.continue()") {
+      return true;
+    }
+
+    return false;
+  }
+
   onStepBegin(test: TestCase, _result: PlaywrightTestResult, step: TestStep): void {
     const testUuid = this.allureResultsUuids.get(test.id)!;
 
@@ -220,8 +233,7 @@ export class AllureReporter implements ReporterV2 {
       return;
     }
 
-    // TODO fix the details disable, e.g. only ignore pw:api steps
-    if (!this.options.detail && step.category !== "test.step") {
+    if (this.#shouldIgnoreStep(step)) {
       return;
     }
 
@@ -232,7 +244,7 @@ export class AllureReporter implements ReporterV2 {
   }
 
   onStepEnd(test: TestCase, _result: PlaywrightTestResult, step: TestStep): void {
-    if (!this.options.detail && step.category !== "test.step") {
+    if (this.#shouldIgnoreStep(step)) {
       return;
     }
 

diff --git a/packages/allure-playwright/test/spec/steps.spec.ts b/packages/allure-playwright/test/spec/steps.spec.ts
@@ -197,3 +197,26 @@ it("should support steps with names longer then 50 chars", async () => {
     }),
   ]);
 });
+
+it("should ignore route.continue() steps", async () => {
+  const { tests } = await runPlaywrightInlineTest({
+    "a.test.js": `
+      import { test, expect } from '@playwright/test';
+
+      test('a test', async ({ page }) => {
+        await page.route('**/*', (route) => {
+          route.continue();
+        });
+        await page.goto("https://allurereport.org");
+      });
+    `,
+  });
+
+  expect(tests).toHaveLength(1);
+  const [tr] = tests;
+  expect(tr.steps).not.toContainEqual(
+    expect.objectContaining({
+      name: "route.continue()",
+    }),
+  );
+});