Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change algo3 to add the ID factor automatically #1

Open
allpan3 opened this issue Sep 11, 2023 · 0 comments
Open

Change algo3 to add the ID factor automatically #1

allpan3 opened this issue Sep 11, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@allpan3
Copy link
Owner

allpan3 commented Sep 11, 2023

Currently, whenever switching to algo3, we have to modify the FACTORS and CODEVECTORS configs to account for the extra ID factor. We should be able to let the dataset class do it.
Note we should not change VSA class to account for algo since algo is not an attribute of VSA. The only place we can do this is the dataset class.
A better solution may be extending the VSA class for algo3, like how we do it in the multi-concept-MNIST project. Let's see if we can get around it without doing so first.

@allpan3 allpan3 added the enhancement New feature or request label Sep 11, 2023
@allpan3 allpan3 self-assigned this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant