Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeoJSON output option for vessel detection pipelines #97

Merged
merged 15 commits into from
Feb 6, 2025

Conversation

favyen2
Copy link
Collaborator

@favyen2 favyen2 commented Feb 4, 2025

Add GeoJSON output option.

I also changed the order in NearInfraFilter to (longitude, latitude) to be consistent with rest of codebase.

And makes crop directory for Sentinel-2 vessel detection pipeline to avoid directory not exist error.

This depends on PR #96.

Resolves #95.

@favyen2 favyen2 marked this pull request as draft February 4, 2025 23:30
@favyen2 favyen2 changed the title [WIP] Add GeoJSON output option for vessel detection pipelines Add GeoJSON output option for vessel detection pipelines Feb 5, 2025
@favyen2 favyen2 marked this pull request as ready for review February 5, 2025 16:58
Copy link
Collaborator

@Hgherzog Hgherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some minor comments

rslp/landsat_vessels/predict_pipeline.py Outdated Show resolved Hide resolved
rslp/landsat_vessels/predict_pipeline.py Show resolved Hide resolved
rslp/sentinel2_vessels/job_launcher.py Outdated Show resolved Hide resolved
rslp/sentinel2_vessels/predict_pipeline.py Outdated Show resolved Hide resolved
rslp/landsat_vessels/predict_pipeline.py Show resolved Hide resolved
@favyen2 favyen2 merged commit 9423691 into master Feb 6, 2025
4 of 5 checks passed
@favyen2 favyen2 deleted the favyen/vessel-detection-geojson branch February 6, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentinel-2 / Landsat vessel detection pipeline improvements
2 participants