Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maldives ecosystem mapping training pipelines #52

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

favyen2
Copy link
Collaborator

@favyen2 favyen2 commented Oct 18, 2024

These aren't used since the README already says to just run model fit directly and I think the train pipeline is kind of pointless since it's just one line and really should just reference the config file (so even if it isn't documented in a README, it should be easy to reproduce).

This resolves #14.

This also removes the class from the pipeline definitions so it just needs to be a function, the class was not used.

These aren't used since the README already says to just run `model fit` directly
and I think the train pipeline is kind of pointless since it's just one line and
really should just reference the config file (so even if it isn't documented in
a README, it should be easy to reproduce).

This resolves #14.

This also removes the class from the pipeline definitions so it just needs to be
a function, the class was not used.
@favyen2 favyen2 requested a review from yawenzzzz October 22, 2024 17:41
Copy link
Collaborator

@yawenzzzz yawenzzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@favyen2 favyen2 merged commit 7938c2f into master Oct 22, 2024
4 checks passed
@favyen2 favyen2 deleted the favyen/issue14 branch October 22, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue with rslp.main run
2 participants