packetloss: ignore non ip packet

alibaba · Apr 7, 2024 · 464ceef · 464ceef
1 parent 0390fe4
commit 464ceef
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/bpf/headers/inspector.h b/bpf/headers/inspector.h
@@ -174,6 +174,10 @@ static __always_inline int set_tuple(struct sk_buff *skb, struct tuple *tpl) {
   l3_off = BPF_CORE_READ(skb, network_header);
   l4_off = BPF_CORE_READ(skb, transport_header);
 
+  if (l3_off == 0){
+    return -1;
+  }
+
   ip = (struct iphdr *)(skb_head + l3_off);
   bpf_probe_read(&iphdr_first_byte, 1, ip);
   ip_vsn = iphdr_first_byte >> 4;

diff --git a/bpf/packetloss.c b/bpf/packetloss.c
@@ -41,7 +41,10 @@ int kfree_skb(struct kfree_skb_args *args) {
   struct sk_buff *skb = (struct sk_buff *)args->skb;
   struct insp_pl_event_t event = {0};
 
-  set_tuple(skb, &event.tuple);
+  if (set_tuple(skb, &event.tuple) < 0){
+    //invalid packet, skip
+    goto out;
+  }
   event.location = (u64)args->location;
 
   if (enable_packetloss_stack){

diff --git a/pkg/exporter/probe/tracepacketloss/bpf_bpfeb.o b/pkg/exporter/probe/tracepacketloss/bpf_bpfeb.o
diff --git a/pkg/exporter/probe/tracepacketloss/bpf_bpfel.o b/pkg/exporter/probe/tracepacketloss/bpf_bpfel.o