refactor(Shell): Upgrade tests and docs, convert to TypeScript #4927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luolin-ck
force-pushed
the
fix-issue-4607
branch
from
66d2eda to
b61524d
Compare
luolin-ck
force-pushed
the
fix-issue-4607
branch
from
33289e2 to
372ead5
Compare
eternalsky
requested changes
Sep 20, 2024
eternalsky
requested changes
Sep 30, 2024
components/shell/shell.tsx
Outdated
| @@ -110,27 +141,27 @@ export default function ShellBase(props) { | |||
| } | |||
|
|
|||
| if (this.navigationFixed) { | |||
| const style = {}; | |||
| const style: { marginLeft?: CSSProperties['marginLeft'] } = {}; | |||
There was a problem hiding this comment.
应该 style 自己就是 CSSProperties，其他地方同
luolin-ck
force-pushed
the
fix-issue-4607
branch
from
a1e6edc to
5c162a4
Compare
luolin-ck
force-pushed
the
fix-issue-4607
branch
from
5c162a4 to
9990cdd
Compare
eternalsky
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shell新增功能如下：
1.TS化;
2.文档优化;
3.测试工具升级，用例优化;
close #4607