Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Animate): Technical Upgrade #4719

Merged
merged 6 commits into from
Jan 23, 2024
Merged

chore(Animate): Technical Upgrade #4719

merged 6 commits into from
Jan 23, 2024

Conversation

eternalsky
Copy link
Contributor

No description provided.

@eternalsky eternalsky requested a review from YSMJ1994 January 16, 2024 03:02
@eternalsky eternalsky force-pushed the feat/animate-upgrade branch from 9c0b3b8 to 94854a4 Compare January 17, 2024 12:31
YSMJ1994
YSMJ1994 reviewed Jan 18, 2024
View reviewed changes
@eternalsky eternalsky requested a review from YSMJ1994 January 18, 2024 11:40
@eternalsky
Copy link
Contributor Author

@YSMJ1994 已按照评论内容修改完毕

@eternalsky eternalsky force-pushed the feat/animate-upgrade branch from 0e66a30 to 6a70b25 Compare January 18, 2024 11:48
@YSMJ1994
Copy link
Contributor

原来的 api 命令有些 bug，文档内 ## API 章节下面的其它文档也被删除了，合并一下 master 重新生成一下吧

1 similar comment
@YSMJ1994
Copy link
Contributor

原来的 api 命令有些 bug，文档内 ## API 章节下面的其它文档也被删除了，合并一下 master 重新生成一下吧

@eternalsky eternalsky force-pushed the feat/animate-upgrade branch 2 times, most recently from 53d8fb3 to a7feb6c Compare January 19, 2024 12:06
@eternalsky eternalsky linked an issue Jan 20, 2024 that may be closed by this pull request
【Technical upgrade】Animate #4562
Closed
@eternalsky eternalsky force-pushed the feat/animate-upgrade branch from a7feb6c to fd5b04f Compare January 21, 2024 09:32
YSMJ1994
YSMJ1994 reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

都差不多了， 可以执行一下 eslint，把 warning 也尽量减少一下

@eternalsky eternalsky force-pushed the feat/animate-upgrade branch from fd5b04f to 355bbdb Compare January 22, 2024 11:11
@eternalsky
Copy link
Contributor Author

都差不多了， 可以执行一下 eslint，把 warning 也尽量减少一下

check 了一下，目前总共 15 个 warning，其中 no-unused-vars 11 个，这 11 个都是为了生成 others 用的，不能删掉。除非用 pickOthers 改造，但这样有点更改逻辑。
react/sort-comp 2 个，这个 eslint 规则比较离谱，建议关掉。
还有两个 any 已修复。 @YSMJ1994

@eternalsky eternalsky force-pushed the feat/animate-upgrade branch from 355bbdb to acd433a Compare January 23, 2024 02:19
@eternalsky eternalsky force-pushed the feat/animate-upgrade branch from acd433a to 129e879 Compare January 23, 2024 03:20
@YSMJ1994 YSMJ1994 merged commit c5e6527 into master Jan 23, 2024
3 of 5 checks passed
@YSMJ1994 YSMJ1994 deleted the feat/animate-upgrade branch January 23, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YSMJ1994 YSMJ1994 YSMJ1994 approved these changes

Assignees
No one assigned
Labels
Technical Upgrade
Projects
Technical upgrade
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

【Technical upgrade】Animate
2 participants
@eternalsky @YSMJ1994