Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/box update #4685

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Feat/box update #4685

merged 2 commits into from
Jan 25, 2024

Conversation

YunMeng99
Copy link
Contributor

@YunMeng99 YunMeng99 commented Dec 27, 2023 •
edited by eternalsky
Loading

close #4566

@YunMeng99 YunMeng99 linked an issue Jan 2, 2024 that may be closed by this pull request
【Technical upgrade】Box #4566
Closed
@YunMeng99 YunMeng99 removed a link to an issue Jan 2, 2024
【Technical upgrade】Box #4566
Closed
YSMJ1994
YSMJ1994 reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外，master有更新，合并一下后运行类型检查，根据错误提示调整下代码

@YunMeng99 YunMeng99 requested a review from YSMJ1994 January 17, 2024 08:04
YSMJ1994
YSMJ1994 reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 调整一下所有 import * as xxx 的语法，改为 import xxx
  2. 整理一下 commit

@YunMeng99 YunMeng99 requested a review from YSMJ1994 January 17, 2024 12:39
@eternalsky eternalsky changed the title Feat/box update Feat/box update，close #4566 Jan 20, 2024
@eternalsky eternalsky changed the title Feat/box update，close #4566 Feat/box update Jan 20, 2024
YSMJ1994
YSMJ1994 requested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit 格式不标准，参考文档整理一下 commit 吧

YSMJ1994
YSMJ1994 requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有一些小问题，看下

@YSMJ1994 YSMJ1994 merged commit e1805e2 into alibaba-fusion:master Jan 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YSMJ1994 YSMJ1994 YSMJ1994 approved these changes

Assignees
No one assigned
Labels
Technical Upgrade
Projects
Technical upgrade
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

【Technical upgrade】Box
3 participants
@YunMeng99 @YSMJ1994 @eternalsky