Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update actions runner to support released xcode 16 #331

Merged
merged 3 commits into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/carthage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ name: Carthage
on: [pull_request]
jobs:
check:
runs-on: macos-12
runs-on: macos-13
steps:
- name: Select Xcode version
run: sudo xcode-select -s '/Applications/Xcode_13.4.app/Contents/Developer'
run: sudo xcode-select -s '/Applications/Xcode_14.2.app/Contents/Developer'
- name: Initialize Cartfile
run: |
tee Cartfile <<<"github \"algolia/instantsearch-ios\" \"${{ github.head_ref }}\""
carthage update --no-build
sh ./Carthage/Checkouts/instantsearch-ios/carthage-prebuild
carthage build --use-xcframeworks --platform ios
carthage build --use-xcframeworks --platform ios
8 changes: 4 additions & 4 deletions .github/workflows/pods.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,31 @@ name: Cocoapods
on: [pull_request]
jobs:
lint-Insights:
runs-on: macos-12
runs-on: macos-13
steps:
- uses: actions/checkout@v4
- name: Select Xcode version
run: sudo xcode-select -s '/Applications/Xcode_14.2.app/Contents/Developer'
- name: lint Insights
run: pod lib lint --subspec="Insights" --allow-warnings
lint-Core:
runs-on: macos-12
runs-on: macos-13
steps:
- uses: actions/checkout@v4
- name: Select Xcode version
run: sudo xcode-select -s '/Applications/Xcode_14.2.app/Contents/Developer'
- name: lint Core
run: pod lib lint --subspec="Core" --allow-warnings
lint-UI:
runs-on: macos-12
runs-on: macos-13
steps:
- uses: actions/checkout@v4
- name: Select Xcode version
run: sudo xcode-select -s '/Applications/Xcode_14.2.app/Contents/Developer'
- name: lint UI
run: pod lib lint --subspec="UI" --allow-warnings
lint-SwiftUI:
runs-on: macos-12
runs-on: macos-13
steps:
- uses: actions/checkout@v4
- name: Select Xcode version
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/swift.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [pull_request]

jobs:
test:
runs-on: macos-12
runs-on: macos-13
env:
ALGOLIA_APPLICATION_ID_1: ${{ secrets.ALGOLIA_APPLICATION_ID_1 }}
ALGOLIA_ADMIN_KEY_1: ${{ secrets.ALGOLIA_ADMIN_KEY_1 }}
Expand All @@ -17,7 +17,7 @@ jobs:
- name: Run tests
run: swift test
test-xcode-16:
runs-on: macos-14
runs-on: macos-15
env:
ALGOLIA_APPLICATION_ID_1: ${{ secrets.ALGOLIA_APPLICATION_ID_1 }}
ALGOLIA_ADMIN_KEY_1: ${{ secrets.ALGOLIA_ADMIN_KEY_1 }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class DecodingErrorPrettyPrinterTests: XCTestCase {
prettyPrinter.description
== "Decoding error: 'age': Expected Int value but found null instead."
|| prettyPrinter.description
== "Decoding error: 'age': Cannot get unkeyed decoding container -- found null value instead"
== "Decoding error: 'age': Cannot get value of type Int -- found null value instead"
)
}
}
Expand Down