From c7e79a212203a98f8dc5255aac3bc66c5aec55b2 Mon Sep 17 00:00:00 2001 From: Dhaya <154633+dhayab@users.noreply.github.com> Date: Mon, 18 Nov 2024 14:57:08 +0100 Subject: [PATCH 1/3] ci: update actions runner to support released xcode 16 --- .github/workflows/swift.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/swift.yml b/.github/workflows/swift.yml index d2b73de9..6c37be46 100644 --- a/.github/workflows/swift.yml +++ b/.github/workflows/swift.yml @@ -17,7 +17,7 @@ jobs: - name: Run tests run: swift test test-xcode-16: - runs-on: macos-14 + runs-on: macos-15 env: ALGOLIA_APPLICATION_ID_1: ${{ secrets.ALGOLIA_APPLICATION_ID_1 }} ALGOLIA_ADMIN_KEY_1: ${{ secrets.ALGOLIA_ADMIN_KEY_1 }} From 96a165c3440d753acc809ae0991e20242e320ff4 Mon Sep 17 00:00:00 2001 From: Dhaya <154633+dhayab@users.noreply.github.com> Date: Mon, 18 Nov 2024 15:42:43 +0100 Subject: [PATCH 2/3] update test --- .../Unit/DecodingErrorPrettyPrinterTests.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tests/InstantSearchCoreTests/Unit/DecodingErrorPrettyPrinterTests.swift b/Tests/InstantSearchCoreTests/Unit/DecodingErrorPrettyPrinterTests.swift index 592eaeb8..43428f82 100644 --- a/Tests/InstantSearchCoreTests/Unit/DecodingErrorPrettyPrinterTests.swift +++ b/Tests/InstantSearchCoreTests/Unit/DecodingErrorPrettyPrinterTests.swift @@ -38,7 +38,7 @@ class DecodingErrorPrettyPrinterTests: XCTestCase { prettyPrinter.description == "Decoding error: 'age': Expected Int value but found null instead." || prettyPrinter.description - == "Decoding error: 'age': Cannot get unkeyed decoding container -- found null value instead" + == "Decoding error: 'age': Cannot get value of type Int -- found null value instead" ) } } From c629c837b9168ae76e3ca37279afaeeb4fca13da Mon Sep 17 00:00:00 2001 From: Dhaya <154633+dhayab@users.noreply.github.com> Date: Mon, 18 Nov 2024 16:06:34 +0100 Subject: [PATCH 3/3] update jobs relying on deprecated macos-12 runner See: https://github.com/actions/runner-images/issues/10721 --- .github/workflows/carthage.yml | 6 +++--- .github/workflows/pods.yml | 8 ++++---- .github/workflows/swift.yml | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/carthage.yml b/.github/workflows/carthage.yml index f21854ce..8f02e03a 100644 --- a/.github/workflows/carthage.yml +++ b/.github/workflows/carthage.yml @@ -2,13 +2,13 @@ name: Carthage on: [pull_request] jobs: check: - runs-on: macos-12 + runs-on: macos-13 steps: - name: Select Xcode version - run: sudo xcode-select -s '/Applications/Xcode_13.4.app/Contents/Developer' + run: sudo xcode-select -s '/Applications/Xcode_14.2.app/Contents/Developer' - name: Initialize Cartfile run: | tee Cartfile <<<"github \"algolia/instantsearch-ios\" \"${{ github.head_ref }}\"" carthage update --no-build sh ./Carthage/Checkouts/instantsearch-ios/carthage-prebuild - carthage build --use-xcframeworks --platform ios \ No newline at end of file + carthage build --use-xcframeworks --platform ios diff --git a/.github/workflows/pods.yml b/.github/workflows/pods.yml index f727b7f3..b7e0c230 100644 --- a/.github/workflows/pods.yml +++ b/.github/workflows/pods.yml @@ -2,7 +2,7 @@ name: Cocoapods on: [pull_request] jobs: lint-Insights: - runs-on: macos-12 + runs-on: macos-13 steps: - uses: actions/checkout@v4 - name: Select Xcode version @@ -10,7 +10,7 @@ jobs: - name: lint Insights run: pod lib lint --subspec="Insights" --allow-warnings lint-Core: - runs-on: macos-12 + runs-on: macos-13 steps: - uses: actions/checkout@v4 - name: Select Xcode version @@ -18,7 +18,7 @@ jobs: - name: lint Core run: pod lib lint --subspec="Core" --allow-warnings lint-UI: - runs-on: macos-12 + runs-on: macos-13 steps: - uses: actions/checkout@v4 - name: Select Xcode version @@ -26,7 +26,7 @@ jobs: - name: lint UI run: pod lib lint --subspec="UI" --allow-warnings lint-SwiftUI: - runs-on: macos-12 + runs-on: macos-13 steps: - uses: actions/checkout@v4 - name: Select Xcode version diff --git a/.github/workflows/swift.yml b/.github/workflows/swift.yml index 6c37be46..e231a7f3 100644 --- a/.github/workflows/swift.yml +++ b/.github/workflows/swift.yml @@ -4,7 +4,7 @@ on: [pull_request] jobs: test: - runs-on: macos-12 + runs-on: macos-13 env: ALGOLIA_APPLICATION_ID_1: ${{ secrets.ALGOLIA_APPLICATION_ID_1 }} ALGOLIA_ADMIN_KEY_1: ${{ secrets.ALGOLIA_ADMIN_KEY_1 }}