Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add privacy manifest #312

Merged
merged 6 commits into from
Apr 26, 2024
Merged

chore: add privacy manifest #312

merged 6 commits into from
Apr 26, 2024

Conversation

aallam
Copy link
Member

@aallam aallam commented Apr 24, 2024

Summary

  • Create PrivacyInfo.xcprivacy
  • Add privacy manifest resource to Package.swift and InstantSearch.podspec

@aallam aallam force-pushed the chore/privacy-manifest branch from 3b6f438 to f36d4e7 Compare April 24, 2024 12:29
@aallam aallam requested review from tkrugg and Fluf22 April 24, 2024 12:51
Fluf22
Fluf22 reviewed Apr 24, 2024
View reviewed changes
Copy link

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When copying resource files, you're in the source code folder at this point, so you need to go back a few folders to access the manifest

image image

Package.swift Outdated Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
@aallam aallam requested a review from Fluf22 April 26, 2024 08:57
Fluf22
Fluf22 approved these changes Apr 26, 2024
View reviewed changes
Copy link

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@aallam aallam force-pushed the chore/privacy-manifest branch from bb6156a to 97e31b2 Compare April 26, 2024 09:56
@aallam aallam merged commit b084cc7 into master Apr 26, 2024
16 checks passed
@aallam aallam deleted the chore/privacy-manifest branch April 26, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fluf22 Fluf22 Fluf22 approved these changes

@tkrugg tkrugg Awaiting requested review from tkrugg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aallam @Fluf22