Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readOnly rows implemented. #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

0xMarK
Copy link

@0xMarK 0xMarK commented Nov 19, 2012

Now there can be some values that cannot be checked/unchecked. Their
initial selection state will remain read-only.

Now there can be some values that cannot be checked/unchecked. Their
initial selection state will remain read-only.
@alexleutgoeb
Copy link
Owner

Thanks for your pull request. I'm not sure if this is a feature that will be used quite often, so we should make this delegate method at least (at)optional.

Can you point out some use case where this might be useful?

Cheers,
Alex

@0xMarK
Copy link
Author

0xMarK commented Nov 20, 2012

I'm developing an enterprise application with a complicated user access rights. In few places the app must forbid the user from unchecking some rows while letting editing all other rows. (The user can only see that the row is checked)

I've integrated this modified version to my project and it works great!

Of course this feature isn't needed often. So you are absolutely right, I will make the delegate method optional.

ALPickerViewDelegate method pickerView:readOnlyStateForRow: made
optional.
@alexleutgoeb
Copy link
Owner

Thank you, that looks good, will test this in one of my own apps and merge your pr in master shortly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants