Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining temp files #279

Open
HolyGit12 opened this issue Jan 23, 2025 · 2 comments
Open

Remaining temp files #279

HolyGit12 opened this issue Jan 23, 2025 · 2 comments

Comments

@HolyGit12
Copy link

crf-search does not delete all temp files after finishing the search.
The both files of the last sample are staying in the temp folder. The temp folder won't be removed.
(Windows version but I guess that this does not matter)

@9Oc
Copy link

9Oc commented Jan 29, 2025

I am also experiencing this after the newest version [0.9.1] with the sample-encode command as well.

@alexheretic
Copy link
Owner

It's possible a recent ffmpeg process is still alive and prevents cleanup. I recently removed logic that would, a little too eagerly, kill ffmpeg so this makes sense.

So I'll look at adding graceful shutdown of these child processes which should resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants