Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use container names for netem --target #90

Open
Tyson1986 opened this issue Jun 20, 2018 · 4 comments
Open

Add ability to use container names for netem --target #90

Tyson1986 opened this issue Jun 20, 2018 · 4 comments

Comments

@Tyson1986
Copy link

Tyson1986 commented Jun 20, 2018

Now it uses IP\IPs for filtering.
As enhancement will be good to add ability to use container names
To get IP of container i use:
docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' <my_container_name>
But may be better solution.

@alexei-led
Copy link
Owner

@Tyson1986 container names are much better, I wanted to do this, just it requires bigger effort. Will keep this issue open.

@Tyson1986
Copy link
Author

I've looked existed issues, and found that we have already discussed this topic in:
#24
And both forgot about it. So one can be closed :)

@Dieterbe
Copy link
Contributor

Dieterbe commented Nov 9, 2018

is pretty easy to do with the docker client.
see https://github.com/grafana/metrictank/blob/1003db861aa5943d70b481f07cabbdff735967f8/stacktest/docker/docker.go#L98-L100

i agree, would be nice to have this available in pumba.

@deanstef
Copy link

deanstef commented Jun 9, 2020

Hello, any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants