Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Diagnostic could be improved #498

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Fix: Diagnostic could be improved #498

merged 3 commits into from
Jan 22, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Dec 8, 2023

Solution:

  • Add checks on the host connectivity, to help with nodes without IPv6 connectivity
  • Add links to troubleshooting docs
  • Move IPv6 Egress in details section, it was confusing to have it on the main page.
    image_2023-12-08_11-27-37
    image_2023-12-08_11-27-37-2
    image_2023-12-08_11-27-37-3

@hoh hoh force-pushed the hoh-better-diagnostic branch from b4106c3 to ae74865 Compare December 8, 2023 11:42
@hoh
Copy link
Member Author

hoh commented Dec 8, 2023

Latest update:
image

Copy link
Member

@BjrInt BjrInt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling with these changes is that we're progressing in the right direction for CRN operators, offering more ways to visualize potential issues.

However the separation between presentation and logic in this specific view is becoming blurrier. We should make sure this does not worsen with new features.

@hoh hoh force-pushed the hoh-better-diagnostic branch from 6b1ff7a to 796cc06 Compare December 11, 2023 11:11
@hoh hoh marked this pull request as ready for review December 11, 2023 11:36
Copy link

Failed to retrieve llama text: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

@nesitor
Copy link
Member

nesitor commented Dec 11, 2023

My feeling with these changes is that we're progressing in the right direction for CRN operators, offering more ways to visualize potential issues.

However the separation between presentation and logic in this specific view is becoming blurrier. We should make sure this does not worsen with new features.

I completely agree with @BjrInt, maybe for the next changes on this page, we should improve that view improving and refactoring the code to avoid feature issues.

@hoh hoh force-pushed the hoh-better-diagnostic branch 2 times, most recently from 8ba504e to 6274e9a Compare December 14, 2023 08:37
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hoh added 3 commits January 12, 2024 14:59
Solution:
- Add checks on the host connectivity, to help with nodes without IPv6 connectivity
- Add links to troubleshooting docs
- Move IPv6 Egress in details section, it was confusing to have it on the main page.
@hoh hoh force-pushed the hoh-better-diagnostic branch from 550af2a to 7d1a0b5 Compare January 12, 2024 13:59
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit 33f95dd into main Jan 22, 2024
18 checks passed
@MHHukiewitz MHHukiewitz deleted the hoh-better-diagnostic branch January 22, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants