-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Diagnostic could be improved #498
Conversation
b4106c3
to
ae74865
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feeling with these changes is that we're progressing in the right direction for CRN operators, offering more ways to visualize potential issues.
However the separation between presentation and logic in this specific view is becoming blurrier. We should make sure this does not worsen with new features.
6b1ff7a
to
796cc06
Compare
Failed to retrieve llama text: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')) |
I completely agree with @BjrInt, maybe for the next changes on this page, we should improve that view improving and refactoring the code to avoid feature issues. |
8ba504e
to
6274e9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Solution: - Add checks on the host connectivity, to help with nodes without IPv6 connectivity - Add links to troubleshooting docs - Move IPv6 Egress in details section, it was confusing to have it on the main page.
550af2a
to
7d1a0b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Solution: