Skip to content

Fix: add missing supported EVM Chains in chain_account_map #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

1yam
Copy link
Member

@1yam 1yam commented Apr 22, 2025

Some chains supported by PyAleph (and the SDK) aren't included in the chain_account_map, which makes them unavailable in aleph-client.

Related Topic : ALEPH-515

Based on :
https://github.com/aleph-im/pyaleph/blob/main/src/aleph/chains/signature_verifier.py#L19

On the accounts map we missing:

  • CSDK
  • NULS
  • NULS2
  • TEZOS
  • NEO
  • BSC
  • INK

This PR add NEO BSC INK since they are EVM chains.

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Apr 22, 2025
Copy link

Summary:
This PR introduces new chains to the SDK, specifically adding support for BSC, INK, and NEO. These changes are primarily focused on expanding the SDK's capabilities by adding new blockchain support, which does not introduce significant risks or complex modifications to existing code.

Highlight:

@@ -26,15 +26,18 @@
     Chain.BASE: ETHAccount,
     Chain.BLAST: EVMAccount,
     Chain.BOB: EVMAccount,
+    Chain.BSC: EVMAccount,
     Chain.CYBER: EVMAccount,
     Chain.DOT: DOTAccount,
     Chain.ECLIPSE: SVMAccount,
     Chain.ETH: ETHAccount,
     Chain.FRAXTAL: EVMAccount,
+    Chain.INK: EVMAccount,
     Chain.LINEA: EVMAccount,
     Chain.LISK: EVMAccount,
     Chain.METIS: EVMAccount,
     Chain.MODE: EVMAccount,
+    Chain.NEO: EVMAccount,
     Chain.OPTIMISM: EVMAccount,
     Chain.POL: EVMAccount,
     Chain.SOL: SOLAccount,

These additions are straightforward and do not alter existing functionalities significantly. They are focused on extending the SDK's capabilities without introducing complex changes to the codebase.

@1yam 1yam requested a review from nesitor April 22, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant