Skip to content

Commit 5c6341a

Browse files
committed
fix merge conflicts on message_types
1 parent a0a1930 commit 5c6341a

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

src/aleph/sdk/base.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ async def get_messages(
166166
pagination: int = DEFAULT_PAGE_SIZE,
167167
page: int = 1,
168168
message_type: Optional[MessageType] = None,
169+
message_types: Optional[Iterable[MessageType]] = None,
169170
content_types: Optional[Iterable[str]] = None,
170171
content_keys: Optional[Iterable[str]] = None,
171172
refs: Optional[Iterable[str]] = None,
@@ -184,7 +185,8 @@ async def get_messages(
184185
185186
:param pagination: Number of items to fetch (Default: 200)
186187
:param page: Page to fetch, begins at 1 (Default: 1)
187-
:param message_type: Filter by message type, can be "AGGREGATE", "POST", "PROGRAM", "VM", "STORE" or "FORGET"
188+
:param message_type: [DEPRECATED] Filter by message type, can be "AGGREGATE", "POST", "PROGRAM", "VM", "STORE" or "FORGET"
189+
:param message_types: Filter by message types, can be any combination of "AGGREGATE", "POST", "PROGRAM", "VM", "STORE" or "FORGET"
188190
:param content_types: Filter by content type
189191
:param content_keys: Filter by aggregate key
190192
:param refs: If set, only fetch posts that reference these hashes (in the "refs" field)
@@ -271,6 +273,7 @@ async def get_message(
271273
def watch_messages(
272274
self,
273275
message_type: Optional[MessageType] = None,
276+
message_types: Optional[Iterable[MessageType]] = None,
274277
content_types: Optional[Iterable[str]] = None,
275278
content_keys: Optional[Iterable[str]] = None,
276279
refs: Optional[Iterable[str]] = None,
@@ -285,7 +288,8 @@ def watch_messages(
285288
"""
286289
Iterate over current and future matching messages asynchronously.
287290
288-
:param message_type: Type of message to watch
291+
:param message_type: [DEPRECATED] Type of message to watch
292+
:param message_types: Types of messages to watch
289293
:param content_types: Content types to watch
290294
:param content_keys: Filter by aggregate key
291295
:param refs: References to watch

src/aleph/sdk/client.py

+3
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ def get_messages(
142142
pagination: int = 200,
143143
page: int = 1,
144144
message_type: Optional[MessageType] = None,
145+
message_types: Optional[List[MessageType]] = None,
145146
content_types: Optional[Iterable[str]] = None,
146147
content_keys: Optional[Iterable[str]] = None,
147148
refs: Optional[Iterable[str]] = None,
@@ -160,6 +161,7 @@ def get_messages(
160161
pagination=pagination,
161162
page=page,
162163
message_type=message_type,
164+
message_types=message_types,
163165
content_types=content_types,
164166
content_keys=content_keys,
165167
refs=refs,
@@ -754,6 +756,7 @@ async def get_messages(
754756
params["msgType"] = message_type.value
755757
if message_types is not None:
756758
params["msgTypes"] = ",".join([t.value for t in message_types])
759+
print(params["msgTypes"])
757760
if content_types is not None:
758761
params["contentTypes"] = ",".join(content_types)
759762
if content_keys is not None:

tests/unit/test_synchronous_get.py

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
def test_get_post_messages():
88
with AlephClient(api_server=settings.API_HOST) as session:
9+
# TODO: Remove deprecated message_type parameter after message_types changes on pyaleph are deployed
910
response: MessagesResponse = session.get_messages(
1011
pagination=2,
1112
message_type=MessageType.post,

0 commit comments

Comments
 (0)