Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Forge) Loose rock generation does not check config value #289

Open
Spoghet99 opened this issue Feb 29, 2024 · 3 comments
Open

(Forge) Loose rock generation does not check config value #289

Spoghet99 opened this issue Feb 29, 2024 · 3 comments

Comments

@Spoghet99
Copy link

I try to turn off loose rock generation but the rocks still generate no matter what i do. In the config i set "enableLooseRocksWorldGen = false" but rocks generate regardless
Minecraft version: 1.20.1
Forge version: 42.2.20

@P4YN-Ki
Copy link

P4YN-Ki commented Apr 17, 2024

I'm also having this issue on these exact versions. No matter what, these little rocks still generate.

@Willusman
Copy link

nolooserocks.zip
You can just make a datapack that removes the rocks from generating for now until this issue is patched.
I attached the datapack that i made for this

@alcatrazEscapee alcatrazEscapee changed the title "enableLooseRocksWorldGen = false" but rocks still generate Loose rock generation does not check config value Sep 6, 2024
@alcatrazEscapee alcatrazEscapee changed the title Loose rock generation does not check config value (Forge) Loose rock generation does not check config value Sep 6, 2024
@alcatrazEscapee
Copy link
Owner

N.B. on Forge,

forge.data(('forge', 'biome_modifier', 'add_loose_rocks'), {
'type': 'forge:add_features',
'biomes': '#minecraft:is_overworld',
'features': 'notreepunching:loose_rocks',
'step': 'top_layer_modification'
})

and on Fabric,

if (Config.INSTANCE.enableLooseRocksWorldGen.getAsBoolean())
{
BiomeModifications.addFeature(
BiomeSelectors.foundInOverworld(),
GenerationStep.Decoration.TOP_LAYER_MODIFICATION,
ModFeatures.LOOSE_ROCKS_KEY
);
}

Fabric appears to be correctly checking the config value; Forge does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants