From 8c5f2b2403384d2a7b7eda5ac0bd3afbb8fdfde2 Mon Sep 17 00:00:00 2001
From: aladinor <aladinor@unal.edu.co>
Date: Sat, 22 Feb 2025 18:37:10 -0600
Subject: [PATCH 1/2] adding template manager file

---
 raw2zarr/template_manager.py | 121 +++++++++++++++++++++++++++++++++++
 1 file changed, 121 insertions(+)
 create mode 100644 raw2zarr/template_manager.py

diff --git a/raw2zarr/template_manager.py b/raw2zarr/template_manager.py
new file mode 100644
index 0000000..67a69d1
--- /dev/null
+++ b/raw2zarr/template_manager.py
@@ -0,0 +1,121 @@
+from pathlib import Path
+from functools import lru_cache
+import json
+import numpy as np
+import xarray as xr
+from pydantic import BaseModel, Field, ConfigDict
+from typing import Dict, List
+
+
+class ScanCoordConfig(BaseModel):
+    model_config = ConfigDict(frozen=True)
+    dims: List[str]
+    dtype: str
+    attributes: Dict = Field(default_factory=dict)
+
+
+class ScanVariableConfig(ScanCoordConfig):
+    fill_value: float = None
+
+
+class ScanConfig(BaseModel):
+    model_config = ConfigDict(frozen=True)
+    # 🛠️ Added missing required fields from JSON structure
+    dims: Dict[str, int]
+    coords: Dict[str, ScanCoordConfig]
+    variables: Dict[str, ScanVariableConfig]
+    metadata: Dict[str, str | float]
+
+
+class ScanTemplateManager:
+    def __init__(self, config_path: Path = Path("config/scan_config.json")):
+        self.config_path = config_path
+        self._full_config = None
+
+    @property
+    def config(self):
+        if self._full_config is None:
+            with open(self.config_path) as f:
+                self._full_config = json.load(f)
+        return self._full_config
+
+    @lru_cache(maxsize=32)
+    def get_template(self, scan_type: str) -> ScanConfig:
+        """Get validated config for specific scan type"""
+        # 🛠️ Added error handling for missing scan types
+        if scan_type not in self.config:
+            raise ValueError(f"Scan type {scan_type} not found in config")
+        return ScanConfig(**self.config[scan_type])
+
+    def create_scan_dataset(
+        self, scan_type: str, elevation: float, radar_info: dict
+    ) -> xr.Dataset:
+        """Generic scan dataset creation"""
+        cfg = self.get_template(scan_type)
+        ds = xr.Dataset()
+
+        # 🛠️ Generalized coordinate creation
+        # Add azimuth coordinate
+        az_cfg = cfg.coords["azimuth"]
+        az_res = 360 / cfg.dims["azimuth"]  # 🛠️ Calculate resolution
+        ds["azimuth"] = xr.DataArray(
+            np.arange(az_res / 2, 360, az_res, dtype=az_cfg.dtype),
+            dims="azimuth",
+            attrs=az_cfg.attributes,
+        )
+        # Add range coordinate
+        range_cfg = cfg.coords["range"]
+        ds["range"] = xr.DataArray(
+            np.arange(
+                range_cfg.attributes["meters_to_center_of_first_gate"],
+                range_cfg.attributes["meters_to_center_of_first_gate"]
+                + range_cfg.attributes["meters_between_gates"] * cfg.dims["range"],
+                range_cfg.attributes["meters_between_gates"],
+                dtype=range_cfg.dtype,
+            ),
+            dims="range",
+            attrs=range_cfg.attributes,
+        )
+
+        # Add radar location
+        ds["longitude"] = xr.DataArray(
+            radar_info["lon"], attrs={"standard_name": "longitude"}
+        )
+
+        ds["latitude"] = xr.DataArray(
+            radar_info["lat"], attrs={"standard_name": "latitude"}
+        )
+
+        ds["altitude"] = xr.DataArray(
+            radar_info["alt"], attrs={"standard_name": "altitude"}
+        )
+
+        # Add variables
+        for var_name, var_cfg in cfg.variables.items():
+            ds[var_name] = xr.DataArray(
+                np.full(
+                    [cfg.dims[d] for d in var_cfg.dims], np.nan, dtype=var_cfg.dtype
+                ),
+                dims=var_cfg.dims,
+                attrs=var_cfg.attributes,
+            )
+
+        # Add time coordinates
+        ds["time"] = xr.DataArray(
+            np.full(
+                cfg.dims["azimuth"],
+                radar_info["reference_time"],
+                dtype="datetime64[ns]",
+            ),
+            dims="azimuth",
+            attrs={"standard_name": "time"},
+        )
+
+        # Add elevation array
+        ds["elevation"] = xr.DataArray(
+            np.full(cfg.dims["azimuth"], elevation, dtype=np.float64),
+            dims="azimuth",
+            attrs=cfg.coords["elevation"].attributes,
+        )
+
+        return ds.xradar.georeference()

From 2ffc8338802f0a66688d1c2f7b45bd927cc78e27 Mon Sep 17 00:00:00 2001
From: aladinor <aladinor@unal.edu.co>
Date: Sat, 22 Feb 2025 18:42:57 -0600
Subject: [PATCH 2/2] fixing lint checker

---
 raw2zarr/template_manager.py | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/raw2zarr/template_manager.py b/raw2zarr/template_manager.py
index 67a69d1..db6e749 100644
--- a/raw2zarr/template_manager.py
+++ b/raw2zarr/template_manager.py
@@ -1,17 +1,17 @@
-from pathlib import Path
-from functools import lru_cache
 import json
+from functools import lru_cache
+from pathlib import Path
+
 import numpy as np
 import xarray as xr
-from pydantic import BaseModel, Field, ConfigDict
-from typing import Dict, List
+from pydantic import BaseModel, ConfigDict, Field
 
 
 class ScanCoordConfig(BaseModel):
     model_config = ConfigDict(frozen=True)
-    dims: List[str]
+    dims: list[str]
     dtype: str
-    attributes: Dict = Field(default_factory=dict)
+    attributes: dict = Field(default_factory=dict)
 
 
 class ScanVariableConfig(ScanCoordConfig):
@@ -21,10 +21,10 @@ class ScanVariableConfig(ScanCoordConfig):
 class ScanConfig(BaseModel):
     model_config = ConfigDict(frozen=True)
     # 🛠️ Added missing required fields from JSON structure
-    dims: Dict[str, int]
-    coords: Dict[str, ScanCoordConfig]
-    variables: Dict[str, ScanVariableConfig]
-    metadata: Dict[str, str | float]
+    dims: dict[str, int]
+    coords: dict[str, ScanCoordConfig]
+    variables: dict[str, ScanVariableConfig]
+    metadata: dict[str, str | float]
 
 
 class ScanTemplateManager: