Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto invoice external subcontractor #53

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

bguillot
Copy link
Member

@bguillot bguillot commented Oct 3, 2024

No description provided.

@bguillot bguillot force-pushed the 16.0-auto-invoice-external branch 2 times, most recently from cd33905 to 3a3237e Compare October 3, 2024 14:25
Copy link
Member

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 general remarks :

  1. Automating the creation of external subcontractor this way, will result on invoices containing the time of different project/ end customer.
    Today, as it is done manually, it is easy to create a filter and invoice the subontracted works in order to do multiple invoices.

Maybe we could always group it the same ways as internal subcontracted work ?
https://github.com/akretion/subcontractor/blob/16.0/account_invoice_subcontractor/models/subcontractor_work.py#L337

Or, if we want to leave the ability to group everything, pass a context from the automatic cron to group the same way only in this case?

  1. This only work for subcontractors, I think you should do the same (= send a mail) in case of an invoice generated for prepaid work.
    But it maybe tricky because those kind of invoices could be generated, then deleted...
    and they won't be validated before receiving the file.

@bguillot bguillot force-pushed the 16.0-auto-invoice-external branch from 3a3237e to 162708c Compare October 7, 2024 15:25
@bguillot bguillot force-pushed the 16.0-auto-invoice-external branch from 162708c to 921c1bb Compare October 7, 2024 15:44
@florian-dacosta florian-dacosta merged commit f984dbc into 16.0 Oct 7, 2024
3 checks passed
@github-grap-bot github-grap-bot deleted the 16.0-auto-invoice-external branch October 7, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants