Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Item Double Tapped Function Add #77

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Item Double Tapped Function Add #77

wants to merge 10 commits into from

Conversation

daesang
Copy link

@daesang daesang commented Mar 29, 2018

daesang added 4 commits March 29, 2018 17:19
Item Double Tapped Function Add
Item Double Tapped Function Add
Item Double Tapped Function Add
Item Double Tapped Function Add
Copy link
Owner

@akgulebubekir akgulebubekir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Daesang,
Thank you for you contribution. There should be some improvements on your implementation before I merge.

@@ -45,6 +45,14 @@ public bool IsRefreshing
public ICommand RefreshCommand { get; set; }
#endregion


public void GridDoubleTapped(ItemTappedEventArgs e)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convenient way to handle a command in ViewModel should be ICommand instead event. You might remove this method or add ICommand to DataGrid.


private void DataGrid_ItemDoubleTapped(object sender, ItemTappedEventArgs e)
{
(this.BindingContext as MainViewModel).GridDoubleTapped(e);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling ViewModel fromXaml is not a good approach. If there is a requirement please create an ICommand.

@@ -417,6 +423,27 @@ public DataGrid(ListViewCachingStrategy cachingStrategy)
}
#endregion

//2018.03.29, gwise@naver.com, Double Tap Function Add.
private int selectedCount = 0;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should move your fields into Fields region on top of the class

//2018.03.29, gwise@naver.com, Double Tap Function Add.
private int selectedCount = 0;
private ItemTappedEventArgs itemTappedEventArgs;
private void DataGrid_ItemTapped(object sender, ItemTappedEventArgs e)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic seems complicated and needs to be simplified. You might use TapGestureRecognizer.

daesang added 5 commits March 30, 2018 01:42
Cell Entry Focus SelectAll Function Add
Cell Entry Focus SelectAll Function Add
Cell Entry Focus SelectAll Function Add
Cell Entry Focus SelectAll Function Add
Cell Entry Focus SelectAll Function Add
@daesang
Copy link
Author

daesang commented Mar 29, 2018

I'm adding...Cell Entry Focus SelectAll Function Add

Cell Entry Focus SelectAll Function Add
@akgulebubekir
Copy link
Owner

Hi Daesang,

On my previous thread I've asked some implementation changes such using TapGestureRecognizer instead a fuzzy logic. In addition that I don't see any relation between Focus effect and your pull request purpose. I'll wait until another thread before taking any action.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants