-
Notifications
You must be signed in to change notification settings - Fork 75
Item Double Tapped Function Add #77
base: master
Are you sure you want to change the base?
Conversation
Item Double Tapped Function Add
Item Double Tapped Function Add
Item Double Tapped Function Add
Item Double Tapped Function Add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Daesang,
Thank you for you contribution. There should be some improvements on your implementation before I merge.
@@ -45,6 +45,14 @@ public bool IsRefreshing | |||
public ICommand RefreshCommand { get; set; } | |||
#endregion | |||
|
|||
|
|||
public void GridDoubleTapped(ItemTappedEventArgs e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convenient way to handle a command in ViewModel should be ICommand instead event. You might remove this method or add ICommand to DataGrid.
|
||
private void DataGrid_ItemDoubleTapped(object sender, ItemTappedEventArgs e) | ||
{ | ||
(this.BindingContext as MainViewModel).GridDoubleTapped(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling ViewModel fromXaml is not a good approach. If there is a requirement please create an ICommand.
@@ -417,6 +423,27 @@ public DataGrid(ListViewCachingStrategy cachingStrategy) | |||
} | |||
#endregion | |||
|
|||
//2018.03.29, gwise@naver.com, Double Tap Function Add. | |||
private int selectedCount = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should move your fields into Fields region on top of the class
//2018.03.29, gwise@naver.com, Double Tap Function Add. | ||
private int selectedCount = 0; | ||
private ItemTappedEventArgs itemTappedEventArgs; | ||
private void DataGrid_ItemTapped(object sender, ItemTappedEventArgs e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic seems complicated and needs to be simplified. You might use TapGestureRecognizer.
Cell Entry Focus SelectAll Function Add
Cell Entry Focus SelectAll Function Add
Cell Entry Focus SelectAll Function Add
Cell Entry Focus SelectAll Function Add
Cell Entry Focus SelectAll Function Add
I'm adding...Cell Entry Focus SelectAll Function Add |
Cell Entry Focus SelectAll Function Add
Hi Daesang, On my previous thread I've asked some implementation changes such using TapGestureRecognizer instead a fuzzy logic. In addition that I don't see any relation between Focus effect and your pull request purpose. I'll wait until another thread before taking any action. |
same like function add.
https://help.syncfusion.com/xamarin/sfdatagrid/grid-events#griddoubletapped-event