Skip to content

feat(alert): implements sufficient notification send interface #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ygrishajev
Copy link
Contributor

No description provided.

@ygrishajev ygrishajev requested a review from a team as a code owner April 25, 2025 14:49
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 92.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 29.11%. Comparing base (7623a61) to head (db35d9b).

Files with missing lines Patch % Lines
...rc/alert/services/deployment/deployment.service.ts 81.48% 5 Missing ⚠️
...alance-alerts/deployment-balance-alerts.service.ts 88.23% 2 Missing ⚠️
...tions/src/alert/model-schemas/alert-base.schema.ts 0.00% 1 Missing ⚠️
...tions/src/notifications/providers/novu.provider.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1284      +/-   ##
==========================================
+ Coverage   28.84%   29.11%   +0.27%     
==========================================
  Files         754      757       +3     
  Lines       18509    18588      +79     
  Branches     3440     3461      +21     
==========================================
+ Hits         5338     5412      +74     
- Misses      12405    12410       +5     
  Partials      766      766              
Flag Coverage Δ *Carryforward flag
api 57.99% <ø> (ø) Carriedforward from 7623a61
deploy-web 9.79% <ø> (ø) Carriedforward from 7623a61
notifications 89.07% <92.50%> (+0.50%) ⬆️
provider-proxy 80.09% <ø> (ø) Carriedforward from 7623a61

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
apps/notifications/src/alert/alert.module.ts 100.00% <100.00%> (ø)
...sitories/contact-point/contact-point.repository.ts 100.00% <100.00%> (ø)
...lert/services/alert-sender/alert-sender.service.ts 100.00% <100.00%> (ø)
...rc/alert/services/raw-alerts/raw-alerts.service.ts 100.00% <100.00%> (ø)
...tions/src/broker/services/broker/broker.service.ts 97.14% <100.00%> (ø)
...ervices/pg-boss-handler/pg-boss-handler.service.ts 96.55% <100.00%> (ø)
...ock-message-parser/block-message-parser.service.ts 98.24% <100.00%> (ø)
...chain-events-poller/chain-events-poller.service.ts 97.40% <100.00%> (ø)
apps/notifications/src/common/common.module.ts 100.00% <100.00%> (ø)
...tions/src/common/services/logger/logger.service.ts 100.00% <ø> (ø)
... and 6 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant