Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem with angle resetting at 360 degrees #6

Open
akapkotel opened this issue Jan 5, 2020 · 0 comments
Open

Fix problem with angle resetting at 360 degrees #6

akapkotel opened this issue Jan 5, 2020 · 0 comments
Assignees
@akapkotel
Labels
bug Something isn't working

Comments

@akapkotel
Copy link
Owner

when vertex closing current wall is in LL quadrant and checked-against corners are in LR quadrant (their angle is not less than max_angle because we 'reset' angle at 260 degrees) or vertex opening current wall is in LR quadrant and corner is in LL quadrant (its angle is larger than in_angle (see update_light_polygon method) in filter builtin, ray is shot which should not be! (temporary fix: replace filter() wit raw rays list (slow!)

The problem "flips" 360 degrees when % 360 is deleted from calculate_angle method.

Picture depicts the problem:
bug
bug2
@akapkotel akapkotel added the bug Something isn't working label Jan 5, 2020
@akapkotel akapkotel self-assigned this Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akapkotel akapkotel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akapkotel