-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Editing is disabled tooltip in readonly mode #5771
Conversation
src/editor.js
Outdated
this.hoverTooltip = new HoverTooltip(); | ||
} | ||
var domNode = dom.createElement("div"); | ||
domNode.innerText = "Editing is disabled"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the nls
utility to allow integrators to translate this string into whatever locale they want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, totally forgot about it, added nls message and covered by tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5771 +/- ##
==========================================
+ Coverage 87.15% 87.16% +0.01%
==========================================
Files 602 603 +1
Lines 44157 44214 +57
Branches 7240 7248 +8
==========================================
+ Hits 38484 38539 +55
- Misses 5673 5675 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It's not related to this change, since we just reuse the HoverTooltip, but my VoiceOver on MacOS in Chrome doesn't read the tooltip content at all. Might work for other browser/OS/SR implementation though. |
@mkslanc Thanks for fixing the failing build! It seems we introduced a merge conflict with this CR, could you resolve that conflict 🙂 |
# Conflicts: # src/autocomplete_test.js
Done :) Hope it helped |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts
) and its references: