Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Editing is disabled tooltip in readonly mode #5771

Merged
merged 6 commits into from
Mar 19, 2025

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Mar 14, 2025

Issue #, if available:

Description of changes:

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

src/editor.js Outdated
this.hoverTooltip = new HoverTooltip();
}
var domNode = dom.createElement("div");
domNode.innerText = "Editing is disabled";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the nls utility to allow integrators to translate this string into whatever locale they want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, totally forgot about it, added nls message and covered by tests

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 97.10145% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.16%. Comparing base (2516181) to head (7fe479e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/editor_options_test.js 92.98% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5771      +/-   ##
==========================================
+ Coverage   87.15%   87.16%   +0.01%     
==========================================
  Files         602      603       +1     
  Lines       44157    44214      +57     
  Branches     7240     7248       +8     
==========================================
+ Hits        38484    38539      +55     
- Misses       5673     5675       +2     
Flag Coverage Δ
unittests 87.16% <97.10%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marinsokol5
Copy link
Contributor

It's not related to this change, since we just reuse the HoverTooltip, but my VoiceOver on MacOS in Chrome doesn't read the tooltip content at all. Might work for other browser/OS/SR implementation though.

@akoreman
Copy link
Contributor

@mkslanc Thanks for fixing the failing build! It seems we introduced a merge conflict with this CR, could you resolve that conflict 🙂

# Conflicts:
#	src/autocomplete_test.js
@mkslanc
Copy link
Contributor Author

mkslanc commented Mar 19, 2025

@mkslanc Thanks for fixing the failing build! It seems we introduced a merge conflict with this CR, could you resolve that conflict 🙂

Done :) Hope it helped

@akoreman akoreman merged commit 1098e53 into ajaxorg:master Mar 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants