New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sound.clearThruster() ID type mismatch #10

Open

ghost opened this issue Nov 9, 2019 · 1 comment

ghost commented Nov 9, 2019

clearThruster() accepts an int player ID from Player.js, but

'thrustersByName' map (see more-renames branch) is keyed by something like "mob_NNNN" or "player_NNNN"

so it looks like that code is dead?

Author

ghost commented Nov 9, 2019

its also called from within Sound.js and those look like sane calls, so it looks like the Player.js calls are probably junk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment