Skip to content

Commit a66a559

Browse files
committed
fix more tests (cloud)
1 parent 2d23857 commit a66a559

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

tests/integration_tests/cloud/test_cloud_sql_reads.py

+15-5
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,14 @@ def previous_job_run_id() -> int:
3333
@pytest.mark.parametrize(
3434
"deployed_connection_id",
3535
[
36-
pytest.param("c7b4d838-a612-495a-9d91-a14e477add51", id="Faker->Snowflake"),
37-
pytest.param("0e1d6b32-b8e3-4b68-91a3-3a314599c782", id="Faker->BigQuery"),
36+
pytest.param(
37+
"c7b4d838-a612-495a-9d91-a14e477add51", # https://cloud.airbyte.com/workspaces/a0cc325a-d358-4df4-bdd4-c09d753b6afb/connections/c7b4d838-a612-495a-9d91-a14e477add51/status
38+
id="Faker->Snowflake",
39+
),
40+
pytest.param(
41+
"0e1d6b32-b8e3-4b68-91a3-3a314599c782", # https://cloud.airbyte.com/workspaces/a0cc325a-d358-4df4-bdd4-c09d753b6afb/connections/0e1d6b32-b8e3-4b68-91a3-3a314599c782/status
42+
id="Faker->BigQuery",
43+
),
3844
pytest.param(
3945
"", id="Faker->Postgres", marks=pytest.mark.skip(reason="Not yet supported")
4046
),
@@ -76,7 +82,11 @@ def test_read_from_deployed_connection(
7682

7783
pandas_df = pd.DataFrame(data_as_list)
7884

79-
assert pandas_df.shape == (100, 20)
85+
assert pandas_df.shape[0] == 100
86+
assert pandas_df.shape[1] in { # Column count diff depending on when it was created
87+
20,
88+
21,
89+
}
8090

8191
# Check that no values are null
8292
for col in pandas_df.columns:
@@ -87,12 +97,12 @@ def test_read_from_deployed_connection(
8797
"deployed_connection_id, cache_type",
8898
[
8999
pytest.param(
90-
"c7b4d838-a612-495a-9d91-a14e477add51",
100+
"c7b4d838-a612-495a-9d91-a14e477add51", # https://cloud.airbyte.com/workspaces/a0cc325a-d358-4df4-bdd4-c09d753b6afb/connections/c7b4d838-a612-495a-9d91-a14e477add51/status
91101
SnowflakeCache,
92102
id="Faker->Snowflake",
93103
),
94104
pytest.param(
95-
"0e1d6b32-b8e3-4b68-91a3-3a314599c782",
105+
"0e1d6b32-b8e3-4b68-91a3-3a314599c782", # https://cloud.airbyte.com/workspaces/a0cc325a-d358-4df4-bdd4-c09d753b6afb/connections/0e1d6b32-b8e3-4b68-91a3-3a314599c782/status
96106
BigQueryCache,
97107
id="Faker->BigQuery",
98108
),

0 commit comments

Comments
 (0)