Fix add more type hints #981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of TopicPartition
Co-authored-by: Denis Otkidach <denis.otkidach@gmail.com>
ods
requested changes
Feb 17, 2024
| return [ | ||
| (topic_name, (new_part.total_count, new_part.new_assignments)) | ||
| for topic_name, new_part in topic_partitions.items() | ||
| ] | ||
|
|
||
| async def create_partitions( | ||
| self, | ||
| topic_partitions: Dict[str, TopicPartition], | ||
| topic_partitions: Dict[str, NewPartitions], |
There was a problem hiding this comment.
It would be nice to fix type name in docstring too
There was a problem hiding this comment.
Hmm… I see it's already NewPartitions in master, it was fixed by your other MR #978
| num_partitions: int, | ||
| replication_factor: int, | ||
| replica_assignments: Optional[Dict[int, List[int]]] = None, | ||
| topic_configs: Optional[Dict[str, str]] = None |
There was a problem hiding this comment.
Please run make format to fix formatting
|
PR #978 is already merged into master, so it looks like a duplicate. Therefore closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add more type hints to integrate with Mypy
reference #980
Checklist
CHANGESfolder