-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client-side impls of custom handshake timeout and custom ping-pong for event handler #173
Conversation
this.sendPong(); | ||
// Heartbeat timeout | ||
if (this._heartbeatTimeout) { | ||
clearTimeout(this._heartbeatTimeout); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the following code be included?
clearTimeout(this._heartbeatTimeout);
this._heartbeatTimeout = null;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just done, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for quickly fixing this issue 🙂
Could the test failure be because the blockchain isn't deployed yet?
Yes, it needs release of the server-side change: ainblockchain/ain-blockchain#1261 |
@platfowner I encountered the following error when building locally. |
just fixed, thanks! |
Thanks for the review! @jiyoung-an Now merging.. and any issues reported would be handled by separate PRs. |
Change summary:
Related issues: