Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client-side impls of custom handshake timeout and custom ping-pong for event handler #173

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

platfowner
Copy link
Member

Change summary:

  • Implement custom handshake timeout for event handler
  • Implement custom ping-pong for heartbeat

Related issues:

@platfowner platfowner added the enhancement New feature or request label Apr 15, 2024
this.sendPong();
// Heartbeat timeout
if (this._heartbeatTimeout) {
clearTimeout(this._heartbeatTimeout);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the following code be included?

clearTimeout(this._heartbeatTimeout);
this._heartbeatTimeout = null;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just done, thanks!

Copy link
Member

@jiyoung-an jiyoung-an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for quickly fixing this issue 🙂
Could the test failure be because the blockchain isn't deployed yet?

@platfowner
Copy link
Member Author

LGTM, thank you for quickly fixing this issue 🙂 Could the test failure be because the blockchain isn't deployed yet?

Yes, it needs release of the server-side change: ainblockchain/ain-blockchain#1261

@jiyoung-an
Copy link
Member

jiyoung-an commented Apr 15, 2024

@platfowner I encountered the following error when building locally.
스크린샷 2024-04-16 오전 1 45 05
I saw this similar error, and adjusted the version of @types/ws to 8.5.3 resolved the issue.
Could you please downgrade the version to 8.5.3?

@platfowner
Copy link
Member Author

@platfowner I encountered the following error when building locally. 스크린샷 2024-04-16 오전 1 45 05 I saw this similar error, and adjusted the version of @types/ws to 8.5.3 resolved the issue. Could you please downgrade the version to 8.5.3?

just fixed, thanks!

@platfowner
Copy link
Member Author

Thanks for the review! @jiyoung-an Now merging.. and any issues reported would be handled by separate PRs.

@platfowner platfowner merged commit 95b4533 into develop Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants