fix configs and settings for chroma for library use #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicl-nno
reviewed
Feb 28, 2025
| @@ -4,13 +4,13 @@ | |||
|
|
|||
|
|
|||
| def _get_omml2mml_transformation() -> etree.XSLT: | |||
| omml2mml_file = Path(Path(__file__).parent, "xsl", "omml2mml", "OMML2MML.XSL") | |||
| omml2mml_file = Path(__file__).parent / "xsl/omml2mml/OMML2MML.XSL" | |||
There was a problem hiding this comment.
А чем такой вариант лучше чем через Path?
There was a problem hiding this comment.
На linux почему-то такой вариант не работал и выдавал лишь относительный путь
nicl-nno
reviewed
Feb 28, 2025
| extra='ignore', | ||
| ) | ||
| docs_processing_config: Optional[str] = None | ||
| docs_collection_path: str = str(Path(dirname(dirname(__file__))) / 'docs' / 'example.docx') |
There was a problem hiding this comment.
А dirname тут критичны, нельзя от корня проекта написать путь (тут и ниже)? Тяжело читается. Да и нужно ли вообще значения по умолчанию с example.docx?
Nunkyl
reviewed
Feb 28, 2025
protollm/rags/configs/chroma.env
Outdated
There was a problem hiding this comment.
этот файл нужен пустой, для чего он?
There was a problem hiding this comment.
У меня такой же вопрос возник, потому и удалил. Технически, ChromaSettings грузилось из него, но смысла с учётом этих ниочёмных параметров в этом мало.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.